@njsiva, I just created a pull request on Github for you. I have added a new capability to your already great plugin which I hope you’ll consider to merge.
Since I bough the dwarf, I was looking for a way to commute effects on/off using a midi controller without having to know their current state to allow the user to take advantage of both snapshots and “stomp mode”. See Toggle (on/off) a plugin with midi - #18 by S_Righteous and Toggle (on/off) a plugin with midi - #18 by S_Righteous .
Consider this use case:
- I recall a clean snapshot
- I add an overdrive sending a CC in the common MOD way (a CC with value=127). Now my controller thinks that the overdrive is on
- I then recall a different snapshot, without overdrive.
- If I want to add an overdrive via midi I will have to push twice my controller (the first will send a CC with value=0, the second with value=127)
So I added to your plugin the possibility to toggle a switch pair trough a midi CC in a different way.
Normally, when a toggle is paired to a CC in the common way, it goes to ON receiving a value >=64, and to OFF otherwise.
This requires that the external controller is able to know the current state of the toggle. There are cases (e.g. loading a snapshot) where this cannot be easily accomplished.
In my implementation, a midi-in port has been added to directly receive CC without the pairing mechanism.
Also, a new parameter (CC) has been added to select the midi_CC to listen for.
When such CC is received, the “value” field is used as the index of the switch pair to be toggled.
E.g. if the CC parameter is set to 19, a midi CC message (control=19, value=0) toggle the first pair. A midi message (control=19, value=1) toggle the second pair and so on, up to the number of available pairs.
Summing it up:
Normal MOD approach to pair a toggle to a midi CC ( control, value) is indexing the switch with the control field and setting it to “value”. There is a “control” for each toggle
My addition allows to use a single CC “control” and addressing the toggles via the “value”, to change their current state.
I hope I have been clear.
Z
Edit: to be clear, the existing features of the plugin has not been affected by the change. You can still pair a midi controller the usual way if you prefer
Edit 2: fixed example as suggested by @Abotte below