Modsdk on macOS

danmh · January 25, 2023, 8:36pm

Hey,

I’m trying to get modsdk running on MacOS (M1) to contribute some png → svg conversions.

I’d love to get it running locally so I can test changes before pushing.

I’m able to install most dependencies via brew & pip.

I am unable to install Pyinotify. Is there anyway I can hack it to not need it to launch?

It looks like a longer term fix might be changing pyinotify to watchdog. From what I can tell it’s cross platform and can do the same things.

Thanks in advance!

falkTX · January 25, 2023, 9:07pm

pyinotify is optional, so you can remove it from the deps on your local repo.

the biggest pain point for mod-sdk is actually the quite old version of tornado it uses, which is no longer compatible with most recent python3 (since 3.10)

if you have a dwarf or duox you can run it directly on the unit.
the images in Developer Images - MOD Wiki provide it accessible through the device, though these image versions are quite old by now too…

danmh · January 25, 2023, 9:14pm

Thank you.

I’m not familiar with python, is that as simple as removing it from requirements.txt?

I do have a dwarf, I’ll also explore running it from there.

falkTX · January 25, 2023, 9:15pm

yes, assuming you are using the usual pyenv things. or whatever the “proper” way of that is now…

danmh · January 25, 2023, 9:20pm

It looks like I’m now hitting the Tornado issue you mentioned previously.

Going to see if I can work out how to use an earlier version of python. Do you think 3.8 would be ok?

brummer · January 26, 2023, 3:19am

Nice to see some progress on this.
I’m using Python 3.10.9. To make it work I use some hacks. For tornado, I use this one:

github.com/moddevices/mod-sdk

make_screenshot ain't work with tornado > 5.0

opened 06:59AM - 26 Nov 18 UTC

brummer10

Hi After a recent update on debian/sid I notice that the screenshot generatio…n ain't work any more. I found that's because in the function `loop.add_handler(proc.stdout.fileno(), proc_callback, 16)` the proc_callback get never called. (with tornado > 5.0) So I've replace that with a watcher thread to make it work for me. Here is a patch to fix the issue with tornado >5.0 Additional I've added a signal handler to catch the KeyboardInterrupt and exit clean. regards hermann ``` diff --git a/modsdk/webserver.py b/modsdk/webserver.py index 5e32201..ffc73e2 100644 --- a/modsdk/webserver.py +++ b/modsdk/webserver.py @@ -3,12 +3,18 @@ import json import os +import sys import random import re import shutil import subprocess import pyinotify +import asyncio +import signal +from threading import Thread +from queue import Queue +from pydispatch import dispatcher from base64 import b64encode from PIL import Image from time import time @@ -511,27 +517,35 @@ class Screenshot(JsonRequestHandler): tmp_filename = ''.join([ random.choice('0123456789abcdef') for i in range(6) ]) return '/tmp/%s.png' % tmp_filename + def proc_callback(self, message): + fh = open(self.fname, 'rb') + os.remove(self.fname) + self.handle_image(fh) + + def proc_watch(self,out, queue): + asyncio.set_event_loop(asyncio.new_event_loop()) + for line in iter(out.readline, b''): + queue.put(line) + out.close() + dispatcher.send(message='screenshoot is ready', signal=self.signal, sender=self.sender) + sys.exit() + def make_screenshot(self): - fname = self.tmp_filename() + self.fname = self.tmp_filename() + self.sender = 'watcher' + self.signal = 'ready' + dispatcher.connect(self.proc_callback, signal=self.signal, sender=self.sender) proc = subprocess.Popen([ PHANTOM_BINARY, SCREENSHOT_SCRIPT, 'http://localhost:%d/icon.html#%s' % (PORT, self.uri), - fname, + self.fname, self.width, self.height, ], stdout=subprocess.PIPE) - - def proc_callback(fileno, event): - if proc.poll() is None: - return - loop.remove_handler(fileno) - fh = open(fname, 'rb') - os.remove(fname) - self.handle_image(fh) - - loop = ioloop.IOLoop.instance() - loop.add_handler(proc.stdout.fileno(), proc_callback, 16) + self.q = Queue() + self.t = Thread(target=self.proc_watch, args=(proc.stdout, self.q)) + self.t.start() def handle_image(self, fh): screenshot_path = self.data['gui']['screenshot'] @@ -786,10 +800,15 @@ def run(): if not check_environment(): return + signal.signal(signal.SIGINT, signal_handler) lv2_init() welcome_message() make_application().start() lv2_cleanup() +def signal_handler(signal, frame): + print(' Thanks for using the MOD-SDK, bye bye.') + sys.exit(0) + if __name__ == "__main__": run() ```

danmh · January 31, 2023, 11:24pm

Thanks both for your input here. I’ve spent another couple of hours hacking around this evening and I just can’t get it too work . I don’t know any python so I’m at the mercy of ChatGPT and StackOverflow.

I’ve got as far as the grey screen telling me I need to load some LV2 plugins, and some terminal error messages saying it can’t find the default pedal board (FileNotFoundError: [Errno 2] No such file or directory: '/opt/homebrew/opt/python@3.9/Frameworks/Python.framework/Versions/3.9/share/mod-sdk/html/resources/templates/pedal-default.html').

I use my Dwarf regularly, so I don’t feel comfortable downgrading it. @falkTX do you think it would be possible to get an up to date developer image?

I’m keen to contribute the png → svg conversions, but I don’t like the thought of committing ‘blind’ with no local testing.

As an alternative, I will try Linux Emulation next time I get a few hours

Edit: one more thought. I do have an RPi 4. Perhaps I can access that remotely in some way. But I’m not sure if the ARM processor makes it more complicated.